Extend TimeSeriesImputer to handle multiple series #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4291 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 355 355
Lines 39458 39511 +53
=======================================
+ Hits 39338 39391 +53
Misses 120 120
☔ View full report in Codecov by Sentry. |
MichaelFu512
requested review from
christopherbunn,
jeremyliweishih,
eccabay and
chukarsten
eccabay
requested changes
Aug 30, 2023
Comment on lines
+749
to
+750
| for col in y: | ||
| y[col] = np.nan |
There was a problem hiding this comment.
I think we would benefit from another test (parametrized here) where only some of the columns are NaN, but not all of them!
There was a problem hiding this comment.
^ Sorry, should have clarified 😅 I meant a test where some of the columns are all NaN, so we drop some columns and impute or pass through others!
eccabay
reviewed
Aug 31, 2023
Comment on lines
+749
to
+750
| for col in y: | ||
| y[col] = np.nan |
There was a problem hiding this comment.
^ Sorry, should have clarified 😅 I meant a test where some of the columns are all NaN, so we drop some columns and impute or pass through others!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Extend TimeSeriesImputer to handle multiple series
Closes #4292
Example picture of what this does
This is the unstacked y from an example multiseries timeseries problem.
The imputer now imputes on it:
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.